Issue 35013003: Revert "Revert "Removing some deprecated members""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 35013003: Revert "Revert "Removing some deprecated members"" (Closed)

Created:
7 years, 2 months ago by blois

Modified:
7 years, 2 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "Revert "Removing some deprecated members"" Take-two of https://code.google.com/p/dart/source/detail?r=29022 The issue with the original was that addEventListener was changed to private, but this caused the IDB classes which override it to not override it any longer. This was breaking C++ multiple inheritance type casts. Fix is to make addEventListener public. BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=29051

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+241 lines, -1269 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	48 chunks	+7 lines, -446 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	117 chunks	+111 lines, -585 lines	0 comments	Download
M	sdk/lib/indexed_db/dartium/indexed_db_dartium.dart	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/web_audio/dart2js/web_audio_dart2js.dart	View	3 chunks	+0 lines, -66 lines	0 comments	Download
M	sdk/lib/web_audio/dartium/web_audio_dartium.dart	View	7 chunks	+4 lines, -70 lines	0 comments	Download
M	tests/html/html.status	View	7 chunks	+0 lines, -7 lines	0 comments	Download
D	tests/html/notifications_test.dart	View	1 chunk	+0 lines, -42 lines	0 comments	Download
M	tools/dom/dom.json	View	20 chunks	+93 lines, -23 lines	0 comments	Download
M	tools/dom/scripts/dartdomgenerator.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/dom/scripts/dartmetadata.py	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/htmldartgenerator.py	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	4 chunks	+7 lines, -14 lines	0 comments	Download
M	tools/dom/src/EventStreamProvider.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_EventTarget.darttemplate	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Emily Fortuna

lgtm, but this makes me sad. Can we update the documentation in dart:html to discourage ...

7 years, 2 months ago (2013-10-22 21:18:15 UTC) #2

blois

7 years, 2 months ago (2013-10-23 00:44:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r29051 (presubmit successful).