Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 34993002: Check const expressions for malformed types. (Closed)

Created:
7 years, 2 months ago by Johnni Winther
Modified:
7 years, 2 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Check const expressions for malformed types. BUG=http://dartbug.com/14299 R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=29080

Patch Set 1 #

Patch Set 2 : Status updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -69 lines) Patch
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 9 chunks +78 lines, -67 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/warnings.dart View 1 chunk +14 lines, -1 line 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download
A tests/language/const_types_test.dart View 1 chunk +84 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +7 lines, -0 lines 0 comments Download
M tests/language/language_analyzer.status View 1 1 chunk +10 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
7 years, 2 months ago (2013-10-22 12:02:12 UTC) #1
ngeoffray
LGTM!
7 years, 2 months ago (2013-10-23 10:43:20 UTC) #2
Johnni Winther
7 years, 2 months ago (2013-10-23 13:02:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r29080 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698