Add support for superSend to the new IR and dart backend.

Add support for superSend to the new IR and dart backend.

Committed: https://code.google.com/p/dart/source/detail?r=37783

[asgerf, 2014-06-23 10:55:18]

https://codereview.chromium.org/349923004/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/dart_backend/dart_printer.dart
(right):

https://codereview.chromium.org/349923004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dart_backend/dart_printer.dart:547:
class Super extends Expression {
There is already a SuperReceiver class for this.

https://codereview.chromium.org/349923004/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart
(right):

https://codereview.chromium.org/349923004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart:181: class
Super extends Expression {
I would prefer that we did this like in dart_tree, since super is not actually
an expression on its own. Alternatively, we could have a separate
InvokeSuperMethod expression, since the only use for super is the receiver in
InvokeMethod.

https://codereview.chromium.org/349923004/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/ir/ir_nodes.dart (right):

https://codereview.chromium.org/349923004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ir/ir_nodes.dart:318: class Super
extends Primitive {
Again, I think it's better to have InvokeSuperMethod rather than a
pseudo-primitive that can only be used as receiver in InvokeMethod.

[sigurdm, 2014-06-24 09:23:08]

https://codereview.chromium.org/349923004/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/dart_backend/dart_printer.dart
(right):

https://codereview.chromium.org/349923004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dart_backend/dart_printer.dart:547:
class Super extends Expression {
On 2014/06/23 10:55:17, asgerf wrote:
> There is already a SuperReceiver class for this.

Thanks - don't know why I could not find it.

https://codereview.chromium.org/349923004/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart
(right):

https://codereview.chromium.org/349923004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart:181: class
Super extends Expression {
On 2014/06/23 10:55:17, asgerf wrote:
> I would prefer that we did this like in dart_tree, since super is not actually
> an expression on its own. Alternatively, we could have a separate
> InvokeSuperMethod expression, since the only use for super is the receiver in
> InvokeMethod.

Good point - did that.

https://codereview.chromium.org/349923004/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/ir/ir_nodes.dart (right):

https://codereview.chromium.org/349923004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ir/ir_nodes.dart:318: class Super
extends Primitive {
On 2014/06/23 10:55:17, asgerf wrote:
> Again, I think it's better to have InvokeSuperMethod rather than a
> pseudo-primitive that can only be used as receiver in InvokeMethod.

Done.

[asgerf, 2014-06-26 07:44:40]

DBC

https://codereview.chromium.org/349923004/diff/100001/sdk/lib/_internal/compi...
File sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart
(right):

https://codereview.chromium.org/349923004/diff/100001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart:139:
Expression receiver;
There should be no receiver

[sigurdm, 2014-06-27 07:50:54]

PTAL

[asgerf, 2014-06-27 08:09:57]

https://codereview.chromium.org/349923004/diff/120001/sdk/lib/_internal/compi...
File sdk/lib/_internal/compiler/implementation/dart_backend/tree_tracer.dart
(right):

https://codereview.chromium.org/349923004/diff/120001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler/implementation/dart_backend/tree_tracer.dart:295:
String receiver = node.receiver.accept(this);
node does not have a receiver

https://codereview.chromium.org/349923004/diff/120001/sdk/lib/_internal/compi...
File sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart (right):

https://codereview.chromium.org/349923004/diff/120001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart:1272: ir.Primitive
getter() {
As discussed offline, we should look for a way to abstract this.

https://codereview.chromium.org/349923004/diff/120001/sdk/lib/_internal/compi...
File sdk/lib/_internal/compiler/implementation/ir/ir_nodes.dart (right):

https://codereview.chromium.org/349923004/diff/120001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler/implementation/ir/ir_nodes.dart:194:
print("${selector.kind} ${arguments};");
Stray print call.

[sigurdm, 2014-06-27 09:20:21]

https://codereview.chromium.org/349923004/diff/120001/sdk/lib/_internal/compi...
File sdk/lib/_internal/compiler/implementation/dart_backend/tree_tracer.dart
(right):

https://codereview.chromium.org/349923004/diff/120001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler/implementation/dart_backend/tree_tracer.dart:295:
String receiver = node.receiver.accept(this);
On 2014/06/27 08:09:56, asgerf wrote:
> node does not have a receiver

Done.

https://codereview.chromium.org/349923004/diff/120001/sdk/lib/_internal/compi...
File sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart (right):

https://codereview.chromium.org/349923004/diff/120001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart:1272: ir.Primitive
getter() {
On 2014/06/27 08:09:56, asgerf wrote:
> As discussed offline, we should look for a way to abstract this.

Done.

https://codereview.chromium.org/349923004/diff/120001/sdk/lib/_internal/compi...
File sdk/lib/_internal/compiler/implementation/ir/ir_nodes.dart (right):

https://codereview.chromium.org/349923004/diff/120001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler/implementation/ir/ir_nodes.dart:194:
print("${selector.kind} ${arguments};");
On 2014/06/27 08:09:56, asgerf wrote:
> Stray print call.

Done.

[sigurdm, 2014-06-27 11:04:11]

Committed patchset #5 manually as r37783 (presubmit successful).