Issue 349643003: Add a function Dart_AllocateWithNativeFields which allocates an object and sets the native fields i…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 349643003: Add a function Dart_AllocateWithNativeFields which allocates an object and sets the native fields i… (Closed)

Created:
6 years, 6 months ago by siva

Modified:
6 years, 6 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add a function Dart_AllocateWithNativeFields which allocates an object and sets the native fields in one call. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=37568

Patch Set 3 : #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -23 lines)			Patch
M	runtime/include/dart_api.h	View		2 chunks	+18 lines, -1 line	1 comment	Download
M	runtime/vm/dart_api_impl.cc	View	1	2 chunks	+56 lines, -18 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View		1 chunk	+9 lines, -4 lines	0 comments	Download
M	runtime/vm/object.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/349643003/diff/40001/runtime/include/dart_api.h File runtime/include/dart_api.h (right): https://codereview.chromium.org/349643003/diff/40001/runtime/include/dart_api.h#newcode2012 runtime/include/dart_api.h:2012: * \param args the Native arguments block passed ...

6 years, 6 months ago (2014-06-20 20:36:59 UTC) #2

siva

6 years, 6 months ago (2014-06-20 21:08:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r37568 (presubmit successful).

Expand Messages | Collapse Messages

Issue 349643003: Add a function Dart_AllocateWithNativeFields which allocates an object and sets the native fields i… (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages