Properly return Windows-formatted paths from package.listFiles.

Properly return Windows-formatted paths from package.listFiles.

In r37514 I incorrectly assumed that the problem was Directory.list
when in fact it's git.

R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37527

[nweiz, 2014-06-20 00:53:26]

On 2014/06/19 23:37:51, nweiz wrote:

TBR

[nweiz, 2014-06-20 00:54:50]

Committed patchset #1 manually as r37527 (presubmit successful).

[Bob Nystrom, 2014-06-20 16:01:57]

One suggestion/question but LGTM.

https://codereview.chromium.org/349503003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/package.dart (right):

https://codereview.chromium.org/349503003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/package.dart:154: return !linkExists(file) ||
fileExists(file);
Stat-ing each file twice is likely going to be a perf hit. How about:

FileSystemEntity.typeSync(file) == FileSystemEntityType.FILE

?

[nweiz, 2014-06-23 20:27:54]

https://codereview.chromium.org/349503003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/package.dart (right):

https://codereview.chromium.org/349503003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/package.dart:154: return !linkExists(file) ||
fileExists(file);
On 2014/06/20 16:01:57, Bob Nystrom wrote:
> Stat-ing each file twice is likely going to be a perf hit. How about:
> 
> FileSystemEntity.typeSync(file) == FileSystemEntityType.FILE
> 
> ?

Actually, just fileExists should work, now that I think about it.