Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 349403003: Fix type error in r37647 (Closed)

Created:
6 years, 6 months ago by Bill Hesse
Modified:
6 years, 6 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M sdk/lib/io/secure_socket.dart View 1 chunk +3 lines, -1 line 2 comments Download

Messages

Total messages: 5 (0 generated)
Bill Hesse
We cannot use the actual type _RawSocket, because that type is only added in the ...
6 years, 6 months ago (2014-06-24 11:14:12 UTC) #1
herhut
https://codereview.chromium.org/349403003/diff/1/sdk/lib/io/secure_socket.dart File sdk/lib/io/secure_socket.dart (right): https://codereview.chromium.org/349403003/diff/1/sdk/lib/io/secure_socket.dart#newcode613 sdk/lib/io/secure_socket.dart:613: (_socket as dynamic)._owner = owner; How about an assignment ...
6 years, 6 months ago (2014-06-24 11:24:31 UTC) #2
herhut
On 2014/06/24 11:24:31, herhut wrote: > https://codereview.chromium.org/349403003/diff/1/sdk/lib/io/secure_socket.dart > File sdk/lib/io/secure_socket.dart (right): > > https://codereview.chromium.org/349403003/diff/1/sdk/lib/io/secure_socket.dart#newcode613 > ...
6 years, 6 months ago (2014-06-24 11:28:12 UTC) #3
Bill Hesse
https://codereview.chromium.org/349403003/diff/1/sdk/lib/io/secure_socket.dart File sdk/lib/io/secure_socket.dart (right): https://codereview.chromium.org/349403003/diff/1/sdk/lib/io/secure_socket.dart#newcode613 sdk/lib/io/secure_socket.dart:613: (_socket as dynamic)._owner = owner; On 2014/06/24 11:24:31, herhut ...
6 years, 6 months ago (2014-06-24 11:29:03 UTC) #4
Bill Hesse
6 years, 6 months ago (2014-06-24 11:30:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r37654 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698