Omits size bits when writing RawObject tags to a snapshot.

Omits size bits when writing RawObject tags to a snapshot.

Makes snapshot ~30KB smaller.

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37626

[zra, 2014-06-23 20:04:12]

PTAL

By also leaving out the class id from the tags, the snapshot size is reduced an
additional ~30KB.

[siva, 2014-06-23 21:45:53]

lgtm

https://codereview.chromium.org/349293002/diff/20001/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/349293002/diff/20001/runtime/vm/snapshot.cc#n...
runtime/vm/snapshot.cc:306: tags = RawObject::ClassIdTag::update(class_id,
tags);
Is it necessary to or in the class_id here? I think all the uses of tags is in
set_tags which only uses the tag bits.

https://codereview.chromium.org/349293002/diff/20001/runtime/vm/snapshot.cc#n...
runtime/vm/snapshot.cc:884: tags = RawObject::ClassIdTag::update(cls_.id(),
tags);
Ditto comment about oring in the class_id

[zra, 2014-06-23 22:17:51]

https://codereview.chromium.org/349293002/diff/20001/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/349293002/diff/20001/runtime/vm/snapshot.cc#n...
runtime/vm/snapshot.cc:306: tags = RawObject::ClassIdTag::update(class_id,
tags);
On 2014/06/23 21:45:53, siva wrote:
> Is it necessary to or in the class_id here? I think all the uses of tags is in
> set_tags which only uses the tag bits.

The class id is taken from tags in TypedData::ReadFrom() and
ExternalTypedData::ReadFrom(). I've moved the or of the class id bits into the
cases, instead.

https://codereview.chromium.org/349293002/diff/20001/runtime/vm/snapshot.cc#n...
runtime/vm/snapshot.cc:884: tags = RawObject::ClassIdTag::update(cls_.id(),
tags);
On 2014/06/23 21:45:53, siva wrote:
> Ditto comment about oring in the class_id

Same as above.

[zra, 2014-06-23 22:18:39]

Committed patchset #3 manually as r37626 (presubmit successful).