Issue 349103003: Migrate protocol_test.dart to reflective tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 349103003: Migrate protocol_test.dart to reflective tests. (Closed)

Created:
6 years, 6 months ago by scheglov

Modified:
6 years, 6 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Migrate protocol_test.dart to reflective tests. 1. Drop static. 2. Replace @runTest with 'test_' method name prefix. 3. Drop direct setUp() invocation. 4. Format. 5. Sort. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=37605

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+377 lines, -443 lines)			Patch
	D	pkg/analysis_server/test/declarative_tests.dart	View		1 chunk	+0 lines, -57 lines	0 comments	Download
	M	pkg/analysis_server/test/protocol_test.dart	View		5 chunks	+377 lines, -386 lines	0 comments	Download

Total messages: 3 (0 generated)

scheglov

6 years, 6 months ago (2014-06-23 15:37:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r37605 (presubmit successful).