Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 34903006: Fix language tests for redirecting factories (issue 14297). (Closed)

Created:
7 years, 2 months ago by regis
Modified:
7 years, 2 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix language tests for redirecting factories (issue 14297). Use target constructor name in redirecting factory errors. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=29045

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M runtime/vm/parser.cc View 1 4 chunks +6 lines, -4 lines 0 comments Download
M tests/language/factory_redirection_test.dart View 1 3 chunks +5 lines, -3 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
regis
7 years, 2 months ago (2013-10-22 21:52:00 UTC) #1
hausner
lgtm
7 years, 2 months ago (2013-10-22 22:18:07 UTC) #2
regis
Thanks!
7 years, 2 months ago (2013-10-22 22:36:30 UTC) #3
regis
7 years, 2 months ago (2013-10-22 22:36:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r29045 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698