Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 34873005: use ShadowCSS directly (Closed)

Created:
7 years, 2 months ago by Jennifer Messerly
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

use ShadowCSS directly also update: ShadowDOM to 2a41b2f5d4d186b9dfcf09fd5a49978eb9ead607 platform/ShadowCSS to 515c58387f48655f38b9bf78de1794861f06f4ad R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=29040

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+423 lines, -326 lines) Patch
pkg/polymer/lib/src/declaration.dart View 2 chunks +5 lines, -20 lines 0 comments Download
pkg/shadow_dom/lib/shadow_dom.debug.js View 12 chunks +208 lines, -153 lines 0 comments Download
pkg/shadow_dom/lib/shadow_dom.min.js View 1 chunk +3 lines, -2 lines 0 comments Download
pkg/shadow_dom/lib/src/platform/ShadowCSS.js View 11 chunks +207 lines, -85 lines 0 comments Download
pkg/shadow_dom/lib/src/platform/patches-shadow-css.js View 1 chunk +0 lines, -65 lines 0 comments Download
pkg/shadow_dom/tool/build.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
This is possible thanks to the new JS interop changes. Note: the code review tool ...
7 years, 2 months ago (2013-10-22 21:34:11 UTC) #1
Siggi Cherem (dart-lang)
lgtm
7 years, 2 months ago (2013-10-22 21:41:08 UTC) #2
Jennifer Messerly
7 years, 2 months ago (2013-10-22 21:42:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r29040 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698