Issue 348493004: Add SpanException and SpanFormatException classes to source_maps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348493004: Add SpanException and SpanFormatException classes to source_maps. (Closed)

Created:
6 years, 6 months ago by nweiz

Modified:
6 years, 6 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add SpanException and SpanFormatException classes to source_maps. It's often useful to associate source range information with an exception in a way that will get printed along with that exception but can be pulled out and manipulated directly. It's especially useful if there's a common superclass/interface for doing so that can be shared across packages. This adds that superclass. R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=37509

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -1 line)			Patch
M	pkg/source_maps/CHANGELOG.md	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/source_maps/lib/span.dart	View	1 chunk	+24 lines, -0 lines	0 comments	Download
M	pkg/source_maps/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

6 years, 6 months ago (2014-06-19 19:29:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r37509 (presubmit successful).

Expand Messages | Collapse Messages