Issue 348313005: Resubmit r37716: Hash tables templates, wrapping Array.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348313005: Resubmit r37716: Hash tables templates, wrapping Array. (Closed)

Created:
6 years, 5 months ago by koda

Modified:
6 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Resubmit r37716: Hash tables templates, wrapping Array. (Patch Set 1 is identical to r37716; Patch Set 2 renames some typedefs to avoid confusing MSVC) Highly customizable to support various internal uses as well as the basis for user-level classes. Use in Library's resolved names cache. Next step is to add new instance classes for the user-level maps/sets (akin to GrowableObjectArray). TBR=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=37800

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+869 lines, -73 lines)			Patch
A	runtime/vm/hash_table.h	View	1	1 chunk	+557 lines, -0 lines	0 comments	Download
A	runtime/vm/hash_table_test.cc	View		1 chunk	+287 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View		5 chunks	+23 lines, -73 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/standalone/issue14236_test.dart	View		Binary file		0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

koda

See the diff between the two patch sets for the typedef renaming that is the ...

6 years, 5 months ago (2014-06-27 21:52:14 UTC) #1

koda

6 years, 5 months ago (2014-06-27 22:34:04 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r37800 (presubmit successful).

Expand Messages | Collapse Messages