Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 347963004: Add a timeout on HttpRequestDataReader (Closed)

Created:
6 years, 6 months ago by Alan Knight
Modified:
6 years, 6 months ago
Reviewers:
vsm, Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a timeout on HttpRequestDataReader BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=37711

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M pkg/intl/lib/src/http_request_data_reader.dart View 1 chunk +26 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Alan Knight
We're getting flaky errors on the Intl package's HTTP reading date tests. I'm suspicious that ...
6 years, 6 months ago (2014-06-25 22:12:40 UTC) #1
Emily Fortuna
lgtm
6 years, 6 months ago (2014-06-25 22:32:46 UTC) #2
Alan Knight
6 years, 6 months ago (2014-06-25 22:43:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37711 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698