Issue 347873002: Ensure that a javascript compatibility warning results in a

Issue 347873002: Ensure that a javascript compatibility warning results in a (Closed)

Created:
6 years, 6 months ago by regis

Modified:
6 years, 6 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Ensure that a javascript compatibility warning results in a JavascriptCompatibilityError being thrown in all cases when --warning_as_error is specified. Prior to this change, some javascript compatibility warnings resulted in a compile time error. Change expectations accordingly in tests. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=37515

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -66 lines)			Patch
M	runtime/vm/compiler.cc	View	1	3 chunks	+2 lines, -13 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1	7 chunks	+12 lines, -43 lines	0 comments	Download
M	tests/standalone/javascript_compatibility_errors_test.dart	View	1	3 chunks	+12 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/347873002/diff/1/runtime/vm/flow_graph_builder.h File runtime/vm/flow_graph_builder.h (right): https://codereview.chromium.org/347873002/diff/1/runtime/vm/flow_graph_builder.h#newcode158 runtime/vm/flow_graph_builder.h:158: bool WarnOnJSIntegralNumTypeTest(AstNode* node, Please add comment describing what ...

6 years, 6 months ago (2014-06-19 20:50:06 UTC) #2

regis

Thanks! https://codereview.chromium.org/347873002/diff/1/runtime/vm/flow_graph_builder.h File runtime/vm/flow_graph_builder.h (right): https://codereview.chromium.org/347873002/diff/1/runtime/vm/flow_graph_builder.h#newcode158 runtime/vm/flow_graph_builder.h:158: bool WarnOnJSIntegralNumTypeTest(AstNode* node, On 2014/06/19 20:50:06, srdjan wrote: ...

6 years, 6 months ago (2014-06-19 20:57:30 UTC) #3

regis

6 years, 6 months ago (2014-06-19 20:57:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r37515 (presubmit successful).

Expand Messages | Collapse Messages