Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 347393003: Fix bugs in Uri: Allow empty port, handle path starting with "//" in toString. (Closed)

Created:
6 years, 6 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 6 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix bugs in Uri: Allow empty port, handle path starting with "//" in toString. R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=37590

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M sdk/lib/core/uri.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M tests/corelib/uri_test.dart View 4 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
6 years, 6 months ago (2014-06-23 09:39:23 UTC) #1
Anders Johnsen
lgtm
6 years, 6 months ago (2014-06-23 09:43:32 UTC) #2
Anders Johnsen
lgtm lgtm
6 years, 6 months ago (2014-06-23 09:43:32 UTC) #3
Lasse Reichstein Nielsen
6 years, 6 months ago (2014-06-23 09:44:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r37590 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698