Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 347153002: Use single quotes for index store. (Closed)

Created:
6 years, 6 months ago by scheglov
Modified:
6 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -41 lines) Patch
M pkg/analysis_server/lib/src/index/split_store.dart View 9 chunks +9 lines, -9 lines 2 comments Download
M pkg/analysis_server/test/index/split_store_test.dart View 20 chunks +33 lines, -32 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
6 years, 6 months ago (2014-06-20 17:41:23 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/347153002/diff/1/pkg/analysis_server/lib/src/index/split_store.dart File pkg/analysis_server/lib/src/index/split_store.dart (right): https://codereview.chromium.org/347153002/diff/1/pkg/analysis_server/lib/src/index/split_store.dart#newcode664 pkg/analysis_server/lib/src/index/split_store.dart:664: * Information about 'universe' elements. We need to ...
6 years, 6 months ago (2014-06-20 18:01:51 UTC) #2
scheglov
Committed patchset #1 manually as r37564 (presubmit successful).
6 years, 6 months ago (2014-06-20 18:20:57 UTC) #3
scheglov
https://codereview.chromium.org/347153002/diff/1/pkg/analysis_server/lib/src/index/split_store.dart File pkg/analysis_server/lib/src/index/split_store.dart (right): https://codereview.chromium.org/347153002/diff/1/pkg/analysis_server/lib/src/index/split_store.dart#newcode664 pkg/analysis_server/lib/src/index/split_store.dart:664: * Information about 'universe' elements. We need to keep ...
6 years, 6 months ago (2014-06-20 18:21:16 UTC) #4
Brian Wilkerson
6 years, 6 months ago (2014-06-21 03:35:03 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698