Issue 347133002: Explicitly remove AnalysisContext from ContextCodec.

Issue 347133002: Explicitly remove AnalysisContext from ContextCodec. (Closed)

Created:
6 years, 6 months ago by scheglov

Modified:
6 years, 6 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Explicitly remove AnalysisContext from ContextCodec. R=paulberry@google.com, brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=37563

Patch Set 2 : Fix for IDs generation #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -7 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/index/file/ContextCodec.java	View	1	3 chunks	+19 lines, -4 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/index/file/SplitIndexStoreImpl.java	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/index/file/ContextCodecTest.java	View	1	1 chunk	+23 lines, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/index/split_store.dart	View	1	3 chunks	+18 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/index/split_store_test.dart	View	1	1 chunk	+25 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

https://codereview.chromium.org/347133002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/index/file/ContextCodec.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/index/file/ContextCodec.java (right): https://codereview.chromium.org/347133002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/index/file/ContextCodec.java#newcode50 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/index/file/ContextCodec.java:50: index = indexToContext.size(); This doesn't work anymore. Now that ...

6 years, 6 months ago (2014-06-20 17:59:02 UTC) #2

scheglov

PTAL https://codereview.chromium.org/347133002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/index/file/ContextCodec.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/index/file/ContextCodec.java (right): https://codereview.chromium.org/347133002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/index/file/ContextCodec.java#newcode50 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/index/file/ContextCodec.java:50: index = indexToContext.size(); Fixed. Thank you. On 2014/06/20 ...

6 years, 6 months ago (2014-06-20 18:09:31 UTC) #3

scheglov

Committed patchset #2 manually as r37563 (presubmit successful).

6 years, 6 months ago (2014-06-20 18:18:17 UTC) #5

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages