Index Dart/HTML units after analysis.

Index Dart/HTML units after analysis.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=37707

[Brian Wilkerson, 2014-06-25 20:57:18]

Despite some picky comments, LGTM.

https://codereview.chromium.org/346963006/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/socket_server.dart (right):

https://codereview.chromium.org/346963006/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/socket_server.dart:37: print('indexDirectory:
$indexDirectory');
Debugging code?

https://codereview.chromium.org/346963006/diff/1/pkg/analysis_server/test/dom...
File pkg/analysis_server/test/domain_search_test.dart (right):

https://codereview.chromium.org/346963006/diff/1/pkg/analysis_server/test/dom...
pkg/analysis_server/test/domain_search_test.dart:22: //  MockServerChannel
serverChannel;
I'm confused. Why did you comment out this code, and why did you write an index
test here?

https://codereview.chromium.org/346963006/diff/1/pkg/analysis_server/test/ind...
File pkg/analysis_server/test/index/index_test.dart (right):

https://codereview.chromium.org/346963006/diff/1/pkg/analysis_server/test/ind...
pkg/analysis_server/test/index/index_test.dart:46: class _LocalIndexTest {
Why is this private? Nobody outside this package could ever access it anyway.

https://codereview.chromium.org/346963006/diff/1/pkg/analysis_server/test/ind...
pkg/analysis_server/test/index/index_test.dart:61: }
nit: I don't see the value of wrapping these two lines in a block, but if it's
really important to you to prevent later code from accessing 'nodeManager'
perhaps we could replace these four lines with

  index = new LocalIndex(new MemoryNodeManager());

https://codereview.chromium.org/346963006/diff/1/pkg/analysis_server/test/moc...
File pkg/analysis_server/test/mocks.dart (right):

https://codereview.chromium.org/346963006/diff/1/pkg/analysis_server/test/moc...
pkg/analysis_server/test/mocks.dart:19: import
'package:analysis_server/src/resource.dart' as pres;
I don't know what "pres" means. I think prefixes should be as meaningful as
other identifiers.

[scheglov, 2014-06-25 21:13:39]

https://codereview.chromium.org/346963006/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/socket_server.dart (right):

https://codereview.chromium.org/346963006/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/socket_server.dart:37: print('indexDirectory:
$indexDirectory');
On 2014/06/25 20:57:18, Brian Wilkerson wrote:
> Debugging code?

Removed.

https://codereview.chromium.org/346963006/diff/1/pkg/analysis_server/test/dom...
File pkg/analysis_server/test/domain_search_test.dart (right):

https://codereview.chromium.org/346963006/diff/1/pkg/analysis_server/test/dom...
pkg/analysis_server/test/domain_search_test.dart:22: //  MockServerChannel
serverChannel;
On 2014/06/25 20:57:18, Brian Wilkerson wrote:
> I'm confused. Why did you comment out this code, and why did you write an
index
> test here?

I started to implement it and found out that it is too big for a single CL.
Uncommented for now.

There was no other way for me to test if indexing actually works, so I wrote
this temporary Server index test here.

https://codereview.chromium.org/346963006/diff/1/pkg/analysis_server/test/ind...
File pkg/analysis_server/test/index/index_test.dart (right):

https://codereview.chromium.org/346963006/diff/1/pkg/analysis_server/test/ind...
pkg/analysis_server/test/index/index_test.dart:46: class _LocalIndexTest {
On 2014/06/25 20:57:18, Brian Wilkerson wrote:
> Why is this private? Nobody outside this package could ever access it anyway.

Done.

https://codereview.chromium.org/346963006/diff/1/pkg/analysis_server/test/ind...
pkg/analysis_server/test/index/index_test.dart:61: }
On 2014/06/25 20:57:18, Brian Wilkerson wrote:
> nit: I don't see the value of wrapping these two lines in a block, but if it's
> really important to you to prevent later code from accessing 'nodeManager'
> perhaps we could replace these four lines with
> 
>   index = new LocalIndex(new MemoryNodeManager());

Inlined.

https://codereview.chromium.org/346963006/diff/1/pkg/analysis_server/test/moc...
File pkg/analysis_server/test/mocks.dart (right):

https://codereview.chromium.org/346963006/diff/1/pkg/analysis_server/test/moc...
pkg/analysis_server/test/mocks.dart:19: import
'package:analysis_server/src/resource.dart' as pres;
On 2014/06/25 20:57:18, Brian Wilkerson wrote:
> I don't know what "pres" means. I think prefixes should be as meaningful as
> other identifiers.

Renamed back.
Problem is that later I declared a local variable with name "resource", so need
to give a different name to either of them. Given that this local variable is
reference less than the prefix, I will rename it to "file" instead.

[scheglov, 2014-06-25 21:14:40]

Committed patchset #2 manually as r37707 (presubmit successful).