Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 346763002: Fix missing + in URI encodeFullTable. (Closed)

Created:
6 years, 6 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 6 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix missing + in URI encodeFullTable. Add tests. BUG= http://dartbug.com/19463 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=37477

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
M sdk/lib/core/uri.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/uri_test.dart View 3 chunks +25 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
6 years, 6 months ago (2014-06-19 07:39:09 UTC) #1
Søren Gjesse
LGTM LEt's consider merging this to 1.5.
6 years, 6 months ago (2014-06-19 07:41:24 UTC) #2
Lasse Reichstein Nielsen
6 years, 6 months ago (2014-06-19 07:44:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37477 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698