Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 346603003: Allow #[] and #[]= symbols. (Closed)

Created:
6 years, 6 months ago by floitsch
Modified:
6 years, 6 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update status file for dart2dart. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M sdk/lib/_internal/compiler/implementation/scanner/scanner.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/corelib/symbol_operator_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
floitsch
6 years, 6 months ago (2014-06-18 18:02:01 UTC) #1
Johnni Winther
lgtm
6 years, 6 months ago (2014-06-18 19:23:48 UTC) #2
floitsch
Updated dart2dart status file. (same test passes there too).
6 years, 6 months ago (2014-06-19 09:29:02 UTC) #3
floitsch
6 years, 6 months ago (2014-06-19 09:29:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r37481 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698