Issue 346553002: Cleanup argument mismatch message.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 346553002: Cleanup argument mismatch message. (Closed)

Created:
6 years, 6 months ago by Johnni Winther

Modified:
6 years, 6 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cleanup argument mismatch message. BUG=http://dartbug.com/13745 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=37447

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -42 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compile_time_constants.dart	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/elements.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	6 chunks	+3 lines, -23 lines	1 comment	Download
M	sdk/lib/_internal/compiler/implementation/warnings.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/resolver_test.dart	View	2 chunks	+0 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

https://codereview.chromium.org/346553002/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (left): https://codereview.chromium.org/346553002/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart#oldcode2736 sdk/lib/_internal/compiler/implementation/resolution/members.dart:2736: warning(node.argumentsNode, MessageKind.INVALID_ARGUMENTS, We always warn in the typechecker so ...

6 years, 6 months ago (2014-06-18 14:32:02 UTC) #1

Johnni Winther

6 years, 6 months ago (2014-06-18 14:53:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r37447 (presubmit successful).

Expand Messages | Collapse Messages