A FileManager implementation to keep each index file in a separate file system file.

A FileManager implementation to keep each index file in a separate file system file.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=37615

[Brian Wilkerson, 2014-06-23 19:52:32]

LGTM

https://codereview.chromium.org/346273005/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/index/store/separate_file_manager.dart (right):

https://codereview.chromium.org/346273005/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/index/store/separate_file_manager.dart:38:
file.deleteSync();
Is it a problem to call deleteSync for a file that doesn't exist? If so, there
is a timing issue here because the file could be deleted externally between the
calls to existsSync and deleteSync. If not, I'm guessing that it's probably
faster to not check.

https://codereview.chromium.org/346273005/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/index/store/separate_file_manager.dart:49: return
file.readAsBytes();
Similar question. If readAsBytes throws an exception when the file doesn't
exist, it might be faster and equally safe (because of possible external
changes) to just try reading it and handle the exception when it is thrown.

[scheglov, 2014-06-23 20:00:22]

https://codereview.chromium.org/346273005/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/index/store/separate_file_manager.dart (right):

https://codereview.chromium.org/346273005/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/index/store/separate_file_manager.dart:38:
file.deleteSync();
On 2014/06/23 19:52:32, Brian Wilkerson wrote:
> Is it a problem to call deleteSync for a file that doesn't exist? If so, there
> is a timing issue here because the file could be deleted externally between
the
> calls to existsSync and deleteSync. If not, I'm guessing that it's probably
> faster to not check.

Done.

https://codereview.chromium.org/346273005/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/index/store/separate_file_manager.dart:49: return
file.readAsBytes();
On 2014/06/23 19:52:32, Brian Wilkerson wrote:
> Similar question. If readAsBytes throws an exception when the file doesn't
> exist, it might be faster and equally safe (because of possible external
> changes) to just try reading it and handle the exception when it is thrown.

Done.

[scheglov, 2014-06-23 20:00:43]

Committed patchset #2 manually as r37615 (presubmit successful).