Issue 34623011: Fixes needed for the deploy step.

Issue 34623011: Fixes needed for the deploy step. (Closed)

Created:
7 years, 2 months ago by Siggi Cherem (dart-lang)

Modified:
7 years, 2 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixes needed for the deploy step. R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=29053

Patch Set 2 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	pkg/custom_element/lib/polyfill.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	pkg/polymer/lib/src/instance.dart	View	1	3 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

https://codereview.chromium.org/34623011/diff/1/pkg/custom_element/lib/polyfill.dart File pkg/custom_element/lib/polyfill.dart (right): https://codereview.chromium.org/34623011/diff/1/pkg/custom_element/lib/polyfill.dart#newcode26 pkg/custom_element/lib/polyfill.dart:26: return document.on['WebComponentsReady'].first; without this some app fail to run ...

7 years, 2 months ago (2013-10-23 00:51:33 UTC) #1

Jennifer Messerly

lgtm https://codereview.chromium.org/34623011/diff/1/pkg/polymer/lib/src/instance.dart File pkg/polymer/lib/src/instance.dart (right): https://codereview.chromium.org/34623011/diff/1/pkg/polymer/lib/src/instance.dart#newcode45 pkg/polymer/lib/src/instance.dart:45: Stream<List<ChangeRecord>> get changes; On 2013/10/23 00:51:33, Siggi Cherem ...

7 years, 2 months ago (2013-10-23 00:56:33 UTC) #2

Siggi Cherem (dart-lang)

thx https://codereview.chromium.org/34623011/diff/1/pkg/polymer/lib/src/instance.dart File pkg/polymer/lib/src/instance.dart (right): https://codereview.chromium.org/34623011/diff/1/pkg/polymer/lib/src/instance.dart#newcode45 pkg/polymer/lib/src/instance.dart:45: Stream<List<ChangeRecord>> get changes; On 2013/10/23 00:56:33, John Messerly ...

7 years, 2 months ago (2013-10-23 01:00:24 UTC) #3

Siggi Cherem (dart-lang)

7 years, 2 months ago (2013-10-23 01:04:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r29053 (presubmit successful).

Expand Messages | Collapse Messages