Fix issue 11534

Fix issue 11534. This improves the performance of the method in question, but doesn't allow us to run the skipped tests. I suspect that there is a new reason why they cannot be run.

R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29031

[scheglov, 2013-10-22 18:35:19]

lgtm

https://codereview.chromium.org/34623004/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java
(right):

https://codereview.chromium.org/34623004/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:4305:
if (path.indexOf(classElt) > 0) {
This is full scan in List, right?
Can it be a reason of slowness?
I see that we need stack-like structure, but may be we have to have here both
List and Set?

[Brian Wilkerson, 2013-10-22 19:54:16]

PTAL

https://codereview.chromium.org/34623004/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java
(right):

https://codereview.chromium.org/34623004/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:4305:
if (path.indexOf(classElt) > 0) {
> Can it be a reason of slowness?

Yes, primarily because of Element.equals(). So I improved the performance of
that method and can now stop skipping the tests. A set might also help here, but
we can explore that later.

[scheglov, 2013-10-22 19:57:52]

LGTM

[Brian Wilkerson, 2013-10-22 20:00:29]

Committed patchset #3 manually as r29031 (presubmit successful).