Issue 345713006: Make size of sample variable based on the profile depth flag

Issue 345713006: Make size of sample variable based on the profile depth flag (Closed)

Created:
6 years, 6 months ago by Cutch

Modified:
6 years, 6 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make size of sample variable based on the profile depth flag. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=37553

Patch Set 5 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -25 lines)			Patch
	M	runtime/vm/profiler.h	View	1 2 3	8 chunks	+34 lines, -24 lines	0 comments	Download
	M	runtime/vm/profiler.cc	View	1 2 3	3 chunks	+38 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTMwC -Ivan https://codereview.chromium.org/345713006/diff/40001/runtime/vm/profiler.h File runtime/vm/profiler.h (right): https://codereview.chromium.org/345713006/diff/40001/runtime/vm/profiler.h#newcode150 runtime/vm/profiler.h:150: uword At(intptr_t i) const; Why have these ...

6 years, 6 months ago (2014-06-20 00:06:49 UTC) #3

Cutch

https://codereview.chromium.org/345713006/diff/40001/runtime/vm/profiler.h File runtime/vm/profiler.h (right): https://codereview.chromium.org/345713006/diff/40001/runtime/vm/profiler.h#newcode150 runtime/vm/profiler.h:150: uword At(intptr_t i) const; On 2014/06/20 00:06:49, Ivan Posva ...

6 years, 6 months ago (2014-06-20 14:39:13 UTC) #4

Cutch

6 years, 6 months ago (2014-06-20 14:46:59 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 manually as r37553 (presubmit successful).

Expand Messages | Collapse Messages