Move String interpolation constant folding from constant propagator to canonicalizer

Move Stringinterpolation constant folding from constant propagator to canonicalizer. StrinIterpolateInstr cannot directlly refer to interpolation arguments but only to the array that holds them, therefore constant propagation cannot be applied.

R=fschneider@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29118

[Florian Schneider, 2013-10-23 17:32:38]

LGTM.

https://codereview.chromium.org/34523007/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/34523007/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language.cc:2748: return this;
Please make sure that the case of an exception is also covered in the test.

https://codereview.chromium.org/34523007/diff/1/tests/language/constant_strin...
File tests/language/constant_string_interpolation.dart (right):

https://codereview.chromium.org/34523007/diff/1/tests/language/constant_strin...
tests/language/constant_string_interpolation.dart:1: // Copyright (c) 2013, the
Dart project authors.  Please see the AUTHORS file
Can you check if test.py runs this test? At some point I remember all tests had
to have _test suffix so that test.py runs it.

[Emily Fortuna, 2013-10-23 17:35:08]

DBC

https://codereview.chromium.org/34523007/diff/1/tests/language/constant_strin...
File tests/language/constant_string_interpolation.dart (right):

https://codereview.chromium.org/34523007/diff/1/tests/language/constant_strin...
tests/language/constant_string_interpolation.dart:1: // Copyright (c) 2013, the
Dart project authors.  Please see the AUTHORS file
On 2013/10/23 17:32:39, Florian Schneider wrote:
> Can you check if test.py runs this test? At some point I remember all tests
had
> to have _test suffix so that test.py runs it.

You're right. test.py won't identify this as a test unless you have "_test.dart"
at the end of the name.

[srdjan, 2013-10-23 20:37:25]

Committed patchset #3 manually as r29118 (presubmit successful).

[srdjan, 2013-10-23 20:39:01]

https://codereview.chromium.org/34523007/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/34523007/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language.cc:2748: return this;
On 2013/10/23 17:32:39, Florian Schneider wrote:
> Please make sure that the case of an exception is also covered in the test.

Changed the code to allow only numbers, strings, boolean and null constants.
This is the same as done in the parser and guarantees that no exception is
thrown and that toString has no side effect.

https://codereview.chromium.org/34523007/diff/1/tests/language/constant_strin...
File tests/language/constant_string_interpolation.dart (right):

https://codereview.chromium.org/34523007/diff/1/tests/language/constant_strin...
tests/language/constant_string_interpolation.dart:1: // Copyright (c) 2013, the
Dart project authors.  Please see the AUTHORS file
On 2013/10/23 17:32:39, Florian Schneider wrote:
> Can you check if test.py runs this test? At some point I remember all tests
had
> to have _test suffix so that test.py runs it.

Thanks, renamed appropriately and checked that it is run.