Issue 345223003: Add VM internal Dart class 'ClassID' used to manage class-ids of known classes. Next CL: add consta…

Issue 345223003: Add VM internal Dart class 'ClassID' used to manage class-ids of known classes. Next CL: add consta… (Closed)

Created:
6 years, 6 months ago by srdjan

Modified:
6 years, 6 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add VM internal Dart class 'ClassID' used to manage class-ids of known classes. Next CL: add constant fields corresponding to each class id (smiCid, oneByteStringCid, etc). R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=37567

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -33 lines)			Patch
M	runtime/lib/array.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
A	runtime/lib/class_id.cc	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
A	runtime/lib/class_id.dart	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/lib/double_patch.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/lib/growable_array.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/lib/internal_sources.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/lib/object.cc	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	runtime/lib/object_patch.dart	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/lib/string_patch.dart	View	1	9 chunks	+10 lines, -9 lines	0 comments	Download
M	runtime/lib/typed_data.dart	View	1	2 chunks	+1 line, -3 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1	1 chunk	+5 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/vm/vm.gypi	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/345223003/diff/1/runtime/lib/class_id.cc File runtime/lib/class_id.cc (right): https://codereview.chromium.org/345223003/diff/1/runtime/lib/class_id.cc#newcode1 runtime/lib/class_id.cc:1: // Copyright (c) 2012, the Dart project authors. ...

6 years, 6 months ago (2014-06-20 20:36:29 UTC) #2

srdjan

https://codereview.chromium.org/345223003/diff/1/runtime/lib/class_id.cc File runtime/lib/class_id.cc (right): https://codereview.chromium.org/345223003/diff/1/runtime/lib/class_id.cc#newcode1 runtime/lib/class_id.cc:1: // Copyright (c) 2012, the Dart project authors. Please ...

6 years, 6 months ago (2014-06-20 20:43:37 UTC) #3

srdjan

6 years, 6 months ago (2014-06-20 20:57:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r37567 (presubmit successful).

Expand Messages | Collapse Messages