Issue 345143002: Handle incremental diagnostics.

Issue 345143002: Handle incremental diagnostics. (Closed)

Created:
6 years, 6 months ago by ahe

Modified:
6 years, 6 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, Johnni Winther, lukechurch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handle incremental diagnostics. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=37596

Patch Set 2 : Merged with r37595. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -17 lines)			Patch
M	dart/site/try/src/compilation.dart	View	6 chunks	+11 lines, -6 lines	0 comments	Download
M	dart/site/try/src/decoration.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/site/try/src/editor.dart	View	2 chunks	+45 lines, -10 lines	0 comments	Download
M	dart/site/try/src/interaction_manager.dart	View	5 chunks	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/345143002/diff/1/dart/site/try/src/editor.dart File dart/site/try/src/editor.dart (right): https://codereview.chromium.org/345143002/diff/1/dart/site/try/src/editor.dart#newcode165 dart/site/try/src/editor.dart:165: if (parent.classes.contains("diagnostic") && Consider factoring this code out ...

6 years, 6 months ago (2014-06-23 06:44:34 UTC) #2

ahe

Thank you, Kasper! https://codereview.chromium.org/345143002/diff/1/dart/site/try/src/editor.dart File dart/site/try/src/editor.dart (right): https://codereview.chromium.org/345143002/diff/1/dart/site/try/src/editor.dart#newcode165 dart/site/try/src/editor.dart:165: if (parent.classes.contains("diagnostic") && On 2014/06/23 06:44:34, ...

6 years, 6 months ago (2014-06-23 12:41:39 UTC) #3

ahe

Committed patchset #2 manually as r37596 (presubmit successful).

6 years, 6 months ago (2014-06-23 12:43:42 UTC) #4

ahe

6 years, 6 months ago (2014-06-23 12:48:48 UTC) #5

Message was sent while issue was closed.

FYI: I've have filed a bug to develop test for this:
https://code.google.com/p/dart/issues/detail?id=19611

Expand Messages | Collapse Messages