Issue 345103002: Remove unused pc-descriptor kind kReturn.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 345103002: Remove unused pc-descriptor kind kReturn. (Closed)

Created:
6 years, 6 months ago by Florian Schneider

Modified:
6 years, 6 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Remove unused pc-descriptor kind kReturn. This kind is not needed since the only place where it is used can be just replaced with kRuntimeCall as it behaves the same. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=37592

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -24 lines)			Patch
M	runtime/vm/debugger.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/debugger_arm.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	runtime/vm/debugger_arm64.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	runtime/vm/debugger_ia32.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	runtime/vm/debugger_mips.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	runtime/vm/debugger_x64.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Florian Schneider

I don't see any reason for this descriptor kind anymore. Is this maybe left-over from ...

6 years, 6 months ago (2014-06-20 14:16:16 UTC) #1

hausner

LGTM. Good catch. At some point, this special PcDescriptor was necessary because the breakpoint got ...

6 years, 6 months ago (2014-06-20 15:47:24 UTC) #2

Florian Schneider

6 years, 6 months ago (2014-06-23 10:51:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r37592 (presubmit successful).