Issue 344953002: Properly handle synchronous errors in Chain.capture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 344953002: Properly handle synchronous errors in Chain.capture. (Closed)

Created:
6 years, 6 months ago by nweiz

Modified:
6 years, 6 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Properly handle synchronous errors in Chain.capture. R=rnystrom@google.com BUG=19542 Committed: https://code.google.com/p/dart/source/detail?r=37520

Patch Set 2 : code review #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -2 lines)			Patch
M	pkg/stack_trace/CHANGELOG.md	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/stack_trace/lib/src/chain.dart	View		1 chunk	+8 lines, -1 line	0 comments	Download
M	pkg/stack_trace/pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/stack_trace/test/chain_test.dart	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

lgtm https://codereview.chromium.org/344953002/diff/1/pkg/stack_trace/pubspec.yaml File pkg/stack_trace/pubspec.yaml (right): https://codereview.chromium.org/344953002/diff/1/pkg/stack_trace/pubspec.yaml#newcode2 pkg/stack_trace/pubspec.yaml:2: version: 1.0.0+1 Let's make this 1.0.1. It's a ...

6 years, 6 months ago (2014-06-19 21:08:45 UTC) #2

nweiz

https://codereview.chromium.org/344953002/diff/1/pkg/stack_trace/pubspec.yaml File pkg/stack_trace/pubspec.yaml (right): https://codereview.chromium.org/344953002/diff/1/pkg/stack_trace/pubspec.yaml#newcode2 pkg/stack_trace/pubspec.yaml:2: version: 1.0.0+1 On 2014/06/19 21:08:45, Bob Nystrom wrote: > ...

6 years, 6 months ago (2014-06-19 21:12:15 UTC) #3

nweiz

6 years, 6 months ago (2014-06-19 21:12:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r37520 (presubmit successful).

Expand Messages | Collapse Messages

Issue 344953002: Properly handle synchronous errors in Chain.capture. (Closed)

Description

Patch Set 1 #

Patch Set 2 : code review #

Messages