Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 344913003: Verify that GC can handle trailing fillers in large pages. (Closed)

Created:
6 years, 6 months ago by koda
Modified:
6 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Verify that GC can handle trailing fillers in large pages. Assert that filler objects created by String::MakeExternal and Array::MakeArray in large pages are never marked. Add unit test that exercises the verification code. R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=37577

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -7 lines) Patch
M runtime/vm/gc_sweeper.cc View 1 chunk +16 lines, -6 lines 0 comments Download
M runtime/vm/object_test.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/vm/pages.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
koda
6 years, 6 months ago (2014-06-21 00:02:11 UTC) #1
rmacnak
LGTM
6 years, 6 months ago (2014-06-21 00:57:42 UTC) #2
Ivan Posva
Daniel, How did you run across this issue? I don't think the filler objects were ...
6 years, 6 months ago (2014-06-21 05:17:37 UTC) #3
koda
On 2014/06/21 05:17:37, Ivan Posva wrote: > Daniel, > > How did you run across ...
6 years, 6 months ago (2014-06-22 00:42:57 UTC) #4
koda
6 years, 6 months ago (2014-06-22 00:49:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r37577 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698