Issue 34473004: Issue 13906. It is still error when typedef references itself using type variable bounds.

Issue 34473004: Issue 13906. It is still error when typedef references itself using type variable bounds. (Closed)

Created:
7 years, 1 month ago by scheglov

Modified:
7 years, 1 month ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 13906. It is still error when typedef references itself using type variable bounds. https://code.google.com/p/dart/issues/detail?id=13906 R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=29010

Patch Set 1 #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -21 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java	View	1 chunk	+3 lines, -3 lines	2 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	tests/co19/co19-analyzer.status	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	tests/language/language_analyzer.status	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/34473004/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java (right): https://codereview.chromium.org/34473004/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java#newcode1129 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java:1129: * compile time error.. nit: extra period https://codereview.chromium.org/34473004/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java#newcode1132 ...

7 years, 1 month ago (2013-10-22 16:59:23 UTC) #2

scheglov

7 years, 1 month ago (2013-10-22 17:07:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r29010 (presubmit successful).

Expand Messages | Collapse Messages