Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 34453003: Rename mdv -> template_binding, remove experiemntal apis from dart:html (Closed)

Created:
7 years, 2 months ago by Jennifer Messerly
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rename mdv -> template_binding, remove experiemntal apis from dart:html essentially, we trade off reduce dart:html API surface area for more annoying usage of these APIs. Since Polymer hides most of this, I suspect it won't be too annoying in practice. Sample usage: nodeBind(node).bind(...) templateBind(node).model = ...; R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=29057

Patch Set 1 #

Patch Set 2 : passing #

Patch Set 3 : #

Total comments: 10

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1057 lines, -6106 lines) Patch
D pkg/mdv/lib/mdv.dart View 1 chunk +0 lines, -104 lines 0 comments Download
D pkg/mdv/lib/src/element.dart View 1 chunk +0 lines, -52 lines 0 comments Download
D pkg/mdv/lib/src/input_bindings.dart View 1 1 chunk +0 lines, -186 lines 0 comments Download
D pkg/mdv/lib/src/input_element.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D pkg/mdv/lib/src/list_diff.dart View 1 chunk +0 lines, -268 lines 0 comments Download
D pkg/mdv/lib/src/node.dart View 1 chunk +0 lines, -132 lines 0 comments Download
D pkg/mdv/lib/src/select_element.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D pkg/mdv/lib/src/template.dart View 1 chunk +0 lines, -104 lines 0 comments Download
D pkg/mdv/lib/src/template_iterator.dart View 1 1 chunk +0 lines, -414 lines 0 comments Download
D pkg/mdv/lib/src/text.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/mdv/lib/src/text_area_element.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D pkg/mdv/pubspec.yaml View 1 chunk +0 lines, -14 lines 0 comments Download
D pkg/mdv/test/analyzer_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D pkg/mdv/test/binding_syntax_test.dart View 1 chunk +0 lines, -202 lines 0 comments Download
D pkg/mdv/test/custom_element_bindings_test.dart View 1 chunk +0 lines, -281 lines 0 comments Download
D pkg/mdv/test/element_bindings_test.dart View 1 chunk +0 lines, -401 lines 0 comments Download
D pkg/mdv/test/mdv_test_utils.dart View 1 chunk +0 lines, -60 lines 0 comments Download
D pkg/mdv/test/node_bindings_test.dart View 1 chunk +0 lines, -155 lines 0 comments Download
D pkg/mdv/test/template_element_test.dart View 1 chunk +0 lines, -1783 lines 0 comments Download
M pkg/polymer/lib/polymer.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/polymer/lib/src/build/runner.dart View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/polymer/lib/src/declaration.dart View 1 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/polymer/lib/src/instance.dart View 1 6 chunks +14 lines, -12 lines 0 comments Download
M pkg/polymer/lib/src/loader.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/attr_mustache_test.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/polymer_expressions/example/example.dart View 1 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/polymer_expressions/example/streams/collect_key_press.html View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/polymer_expressions/example/streams/count_clicks.html View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/polymer_expressions/example/streams/mouse_move.html View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/polymer_expressions/example/streams/mouse_resize_image.html View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/polymer_expressions/lib/eval.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer_expressions/lib/polymer_expressions.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/polymer_expressions/test/bindings_test.dart View 1 4 chunks +7 lines, -8 lines 0 comments Download
M pkg/polymer_expressions/test/eval_test.dart View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/polymer_expressions/test/globals_test.dart View 1 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/polymer_expressions/test/syntax_test.dart View 1 4 chunks +4 lines, -5 lines 0 comments Download
A + pkg/template_binding/lib/src/element.dart View 1 3 chunks +8 lines, -12 lines 0 comments Download
A + pkg/template_binding/lib/src/input_bindings.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + pkg/template_binding/lib/src/input_element.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
A + pkg/template_binding/lib/src/list_diff.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A pkg/template_binding/lib/src/node.dart View 1 2 1 chunk +247 lines, -0 lines 0 comments Download
A + pkg/template_binding/lib/src/select_element.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
A pkg/template_binding/lib/src/template.dart View 1 1 chunk +325 lines, -0 lines 0 comments Download
A + pkg/template_binding/lib/src/template_iterator.dart View 1 12 chunks +28 lines, -32 lines 0 comments Download
A + pkg/template_binding/lib/src/text.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + pkg/template_binding/lib/src/text_area_element.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
A pkg/template_binding/lib/template_binding.dart View 1 2 1 chunk +171 lines, -0 lines 0 comments Download
A pkg/template_binding/pubspec.yaml View 1 chunk +11 lines, -0 lines 0 comments Download
A + pkg/template_binding/test/analyzer_test.dart View 1 1 chunk +9 lines, -11 lines 0 comments Download
A + pkg/template_binding/test/binding_syntax_test.dart View 1 6 chunks +5 lines, -22 lines 0 comments Download
A + pkg/template_binding/test/custom_element_bindings_test.dart View 1 2 3 12 chunks +58 lines, -84 lines 0 comments Download
A + pkg/template_binding/test/element_bindings_test.dart View 1 17 chunks +24 lines, -28 lines 0 comments Download
A + pkg/template_binding/test/node_bindings_test.dart View 1 8 chunks +13 lines, -16 lines 0 comments Download
A + pkg/template_binding/test/template_element_test.dart View 1 2 3 23 chunks +40 lines, -84 lines 0 comments Download
A + pkg/template_binding/test/utils.dart View 1 3 chunks +40 lines, -4 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 7 chunks +1 line, -490 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 6 chunks +1 line, -486 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 2 chunks +0 lines, -140 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 1 1 chunk +0 lines, -6 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLTemplateElement.darttemplate View 1 1 chunk +0 lines, -281 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 2 chunks +0 lines, -67 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jennifer Messerly
apologies for "node.dart" and "template.dart". The code moved from impl_Node and implElement/impl_HTMLTemplateElement, but unfortunately the ...
7 years, 2 months ago (2013-10-23 01:16:11 UTC) #1
Siggi Cherem (dart-lang)
lgtm! https://codereview.chromium.org/34453003/diff/60001/pkg/polymer/lib/src/declaration.dart File pkg/polymer/lib/src/declaration.dart (right): https://codereview.chromium.org/34453003/diff/60001/pkg/polymer/lib/src/declaration.dart#newcode72 pkg/polymer/lib/src/declaration.dart:72: return template != null ? templateBind(template).content : null; ...
7 years, 2 months ago (2013-10-23 01:41:11 UTC) #2
Jennifer Messerly
thanks! https://codereview.chromium.org/34453003/diff/60001/pkg/polymer/lib/src/declaration.dart File pkg/polymer/lib/src/declaration.dart (right): https://codereview.chromium.org/34453003/diff/60001/pkg/polymer/lib/src/declaration.dart#newcode72 pkg/polymer/lib/src/declaration.dart:72: return template != null ? templateBind(template).content : null; ...
7 years, 2 months ago (2013-10-23 02:05:02 UTC) #3
Jennifer Messerly
7 years, 2 months ago (2013-10-23 02:12:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r29057 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698