Issue 344413004: Support pub --with-prejudice.

Issue 344413004: Support pub --with-prejudice. (Closed)

Created:
6 years, 6 months ago by nweiz

Modified:
6 years, 6 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support pub --with-prejudice. R=rnystrom@google.com BUG=13658 Committed: https://code.google.com/p/dart/source/detail?r=37754

Patch Set 2 : code review #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -11 lines)			Patch
M	sdk/lib/_internal/pub/bin/pub.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/command.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/log.dart	View	1	6 chunks	+32 lines, -9 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/progress.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/utils.dart	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/pub_test.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

<3 <3 <3 LGTM! https://codereview.chromium.org/344413004/diff/1/sdk/lib/_internal/pub/lib/src/log.dart File sdk/lib/_internal/pub/lib/src/log.dart (right): https://codereview.chromium.org/344413004/diff/1/sdk/lib/_internal/pub/lib/src/log.dart#newcode229 sdk/lib/_internal/pub/lib/src/log.dart:229: final _format = new RegExp(r'\u001b\[\d+(;\d+)?M'); ...

6 years, 6 months ago (2014-06-26 16:54:11 UTC) #2

nweiz

https://codereview.chromium.org/344413004/diff/1/sdk/lib/_internal/pub/lib/src/log.dart File sdk/lib/_internal/pub/lib/src/log.dart (right): https://codereview.chromium.org/344413004/diff/1/sdk/lib/_internal/pub/lib/src/log.dart#newcode229 sdk/lib/_internal/pub/lib/src/log.dart:229: final _format = new RegExp(r'\u001b\[\d+(;\d+)?M'); On 2014/06/26 16:54:11, Bob ...

6 years, 6 months ago (2014-06-26 20:07:16 UTC) #3

nweiz

6 years, 6 months ago (2014-06-26 20:07:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r37754 (presubmit successful).

Expand Messages | Collapse Messages