Improve incremental compilation.

Improve incremental compilation.

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37595

[kasperl, 2014-06-23 12:15:06]

LGTM.

https://codereview.chromium.org/344203004/diff/60001/dart/site/try/src/cachin...
File dart/site/try/src/caching_compiler.dart (right):

https://codereview.chromium.org/344203004/diff/60001/dart/site/try/src/cachin...
dart/site/try/src/caching_compiler.dart:58: new
UserTag('reuseCompiler').makeCurrent();
Shouldn't you be leaving the reuseCompiler tag at some point?

https://codereview.chromium.org/344203004/diff/60001/dart/tests/compiler/dart...
File dart/tests/compiler/dart2js/incremental/compile_all.dart (right):

https://codereview.chromium.org/344203004/diff/60001/dart/tests/compiler/dart...
dart/tests/compiler/dart2js/incremental/compile_all.dart:96: for (String crash
in crashes) {
Clearly you meant:

  crashes.map((e) => 'Crashed: $e').forEach(print);

:-)

https://codereview.chromium.org/344203004/diff/60001/dart/tests/compiler/dart...
File dart/tests/compiler/dart2js/incremental/hello_test.dart (right):

https://codereview.chromium.org/344203004/diff/60001/dart/tests/compiler/dart...
dart/tests/compiler/dart2js/incremental/hello_test.dart:87: var options = [
Could these common options be shared somehow?

[ahe, 2014-06-23 12:33:28]

Thank you, Kasper!

https://codereview.chromium.org/344203004/diff/60001/dart/site/try/src/cachin...
File dart/site/try/src/caching_compiler.dart (right):

https://codereview.chromium.org/344203004/diff/60001/dart/site/try/src/cachin...
dart/site/try/src/caching_compiler.dart:58: new
UserTag('reuseCompiler').makeCurrent();
On 2014/06/23 12:15:06, kasperl wrote:
> Shouldn't you be leaving the reuseCompiler tag at some point?

Done.

https://codereview.chromium.org/344203004/diff/60001/dart/tests/compiler/dart...
File dart/tests/compiler/dart2js/incremental/compile_all.dart (right):

https://codereview.chromium.org/344203004/diff/60001/dart/tests/compiler/dart...
dart/tests/compiler/dart2js/incremental/compile_all.dart:96: for (String crash
in crashes) {
On 2014/06/23 12:15:06, kasperl wrote:
> Clearly you meant:
> 
>   crashes.map((e) => 'Crashed: $e').forEach(print);
> 
> :-)

Did you mean:

  print(crashes.map((e) => 'Crashed: $e').join('\n'));

https://codereview.chromium.org/344203004/diff/60001/dart/tests/compiler/dart...
File dart/tests/compiler/dart2js/incremental/hello_test.dart (right):

https://codereview.chromium.org/344203004/diff/60001/dart/tests/compiler/dart...
dart/tests/compiler/dart2js/incremental/hello_test.dart:87: var options = [
On 2014/06/23 12:15:06, kasperl wrote:
> Could these common options be shared somehow?

Done.

[ahe, 2014-06-23 12:34:54]

Committed patchset #2 manually as r37595 (presubmit successful).