Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issue 34363005: Filtering MutationObserver polyfill messages from test_controller logging (Closed)

Created:
7 years, 2 months ago by blois
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org, kustermann
Visibility:
Public.

Description

Filtering MutationObserver polyfill messages from test_controller logging Basically the MutationObserver polyfill is using postMessage as a scheduling mechanism when MutationObserver is not supported (IE9,IE10). These messages are getting picked up by the test controller's logging, which is then putting them into the body. This in turn generates new mutation events, generating new messages. Endless loop. This just filters messages which are random numbers. BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=29107

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M pkg/unittest/lib/test_controller.js View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
blois
7 years, 2 months ago (2013-10-23 18:05:22 UTC) #1
blois
For reference, the event is fired from: https://code.google.com/p/dart/source/browse/branches/bleeding_edge/dart/pkg/custom_element/lib/custom-elements.debug.js#72
7 years, 2 months ago (2013-10-23 18:08:18 UTC) #2
Jennifer Messerly
lgtm https://codereview.chromium.org/34363005/diff/1/pkg/unittest/lib/test_controller.js File pkg/unittest/lib/test_controller.js (right): https://codereview.chromium.org/34363005/diff/1/pkg/unittest/lib/test_controller.js#newcode101 pkg/unittest/lib/test_controller.js:101: if (typeof msg != 'string') return; maybe just ...
7 years, 2 months ago (2013-10-23 18:14:31 UTC) #3
blois
https://codereview.chromium.org/34363005/diff/1/pkg/unittest/lib/test_controller.js File pkg/unittest/lib/test_controller.js (right): https://codereview.chromium.org/34363005/diff/1/pkg/unittest/lib/test_controller.js#newcode101 pkg/unittest/lib/test_controller.js:101: if (typeof msg != 'string') return; On 2013/10/23 18:14:32, ...
7 years, 2 months ago (2013-10-23 18:20:22 UTC) #4
blois
7 years, 2 months ago (2013-10-23 18:40:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r29107 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698