Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 343433004: Wrap signal listening with try catch to fix Windows (Closed)

Created:
6 years, 6 months ago by Cutch
Modified:
6 years, 6 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org
Visibility:
Public.

Description

Wrap signal listening with try catch to fix Windows BUG= Committed: https://code.google.com/p/dart/source/detail?r=37398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M runtime/bin/vmservice/vmservice_io.dart View 2 chunks +17 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Cutch
TBR
6 years, 6 months ago (2014-06-17 14:45:00 UTC) #1
Cutch
Committed patchset #1 manually as r37398 (presubmit successful).
6 years, 6 months ago (2014-06-17 14:46:54 UTC) #2
Anders Johnsen
6 years, 6 months ago (2014-06-17 15:38:55 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698