Show partial reports in pub get, serve, and build.

Show partial reports in pub get, serve, and build.

Also add support for --dry-run to pub get.

BUG=dartbug.com/19439 dartbug.com/15587
R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37525

[nweiz, 2014-06-18 23:13:04]

https://codereview.chromium.org/342763003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command/get.dart (right):

https://codereview.chromium.org/342763003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/get.dart:23: help: 'Report what
dependencies would change but do not change any.');
"do not" -> "don't"

https://codereview.chromium.org/342763003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/entrypoint.dart (right):

https://codereview.chromium.org/342763003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/entrypoint.dart:113: /// [isUpgrade] is `true`,
all transitive dependencies are shown in the
Why is [isUpgrade] distinct from [upgradeAll]?

https://codereview.chromium.org/342763003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/solver/solve_report.dart (right):

https://codereview.chromium.org/342763003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/solver/solve_report.dart:34: this._result,
this._showAll) {
[showAll] should be a named parameter.

https://codereview.chromium.org/342763003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/solver/solve_report.dart:46: void show({bool
dryRun: false}) {
[dryRun] isn't use here.

https://codereview.chromium.org/342763003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/solver/solve_report.dart:54: /// If [isUpgrade] is
true, a "pub upgrade" was run, otherwise it was another
[isUpgrade] isn't the name of a parameter.

[Bob Nystrom, 2014-06-19 17:30:19]

Thanks!

https://codereview.chromium.org/342763003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command/get.dart (right):

https://codereview.chromium.org/342763003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/get.dart:23: help: 'Report what
dependencies would change but do not change any.');
On 2014/06/18 23:12:59, nweiz wrote:
> "do not" -> "don't"

Done.

https://codereview.chromium.org/342763003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/entrypoint.dart (right):

https://codereview.chromium.org/342763003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/entrypoint.dart:113: /// [isUpgrade] is `true`,
all transitive dependencies are shown in the
On 2014/06/18 23:12:59, nweiz wrote:
> Why is [isUpgrade] distinct from [upgradeAll]?

No reason. Fixed.

https://codereview.chromium.org/342763003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/solver/solve_report.dart (right):

https://codereview.chromium.org/342763003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/solver/solve_report.dart:34: this._result,
this._showAll) {
On 2014/06/18 23:12:59, nweiz wrote:
> [showAll] should be a named parameter.

Done.

https://codereview.chromium.org/342763003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/solver/solve_report.dart:46: void show({bool
dryRun: false}) {
On 2014/06/18 23:12:59, nweiz wrote:
> [dryRun] isn't use here.

Done.

https://codereview.chromium.org/342763003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/solver/solve_report.dart:54: /// If [isUpgrade] is
true, a "pub upgrade" was run, otherwise it was another
On 2014/06/18 23:12:59, nweiz wrote:
> [isUpgrade] isn't the name of a parameter.

Done.

[nweiz, 2014-06-19 19:39:20]

lgtm

https://codereview.chromium.org/342763003/diff/20001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/command/upgrade.dart (right):

https://codereview.chromium.org/342763003/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/command/upgrade.dart:31: var upgradeAll =
commandOptions.rest.isEmpty;
This variable is now unused.

[Bob Nystrom, 2014-06-19 23:26:48]

Committed patchset #2 manually as r37525 (presubmit successful).

[Bob Nystrom, 2014-06-19 23:28:24]

https://codereview.chromium.org/342763003/diff/20001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/command/upgrade.dart (right):

https://codereview.chromium.org/342763003/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/command/upgrade.dart:31: var upgradeAll =
commandOptions.rest.isEmpty;
On 2014/06/19 19:39:20, nweiz wrote:
> This variable is now unused.

Done.