Issue 342533003: fix type annotation of $

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 342533003: fix type annotation of $ (Closed)

Created:
6 years, 6 months ago by Jennifer Messerly

Modified:
6 years, 6 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	pkg/polymer/lib/src/instance.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	pkg/polymer/pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Jennifer Messerly

the $ map couldn't be used as intended because the return type was incorrect. Almost ...

6 years, 6 months ago (2014-06-17 21:45:59 UTC) #1

Siggi Cherem (dart-lang)

lgtm - let's update the version to 0.11.0-dev.5.dev or just -dev.5 and release it :)

6 years, 6 months ago (2014-06-17 22:15:26 UTC) #2

Jennifer Messerly

6 years, 6 months ago (2014-06-17 22:21:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r37428 (presubmit successful).