Issue 342503002: Heap::AllocateExternal may trigger GC, so fix String::MakeExternal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 342503002: Heap::AllocateExternal may trigger GC, so fix String::MakeExternal. (Closed)

Created:
6 years, 6 months ago by koda

Modified:
6 years, 6 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Heap::AllocateExternal may trigger GC, so fix String::MakeExternal. Note that this may happen even for size 0 (since we may be overdue for a GC). Some unit tests still optimistically expect that GC will not trigger. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=37414

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -58 lines)			Patch
M	runtime/vm/dart_api_state.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/heap.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View		1 chunk	+65 lines, -58 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

koda

Note: The diff is misleading; most of it is just an indentation change.

6 years, 6 months ago (2014-06-17 18:14:54 UTC) #2

koda

6 years, 6 months ago (2014-06-17 19:41:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r37414 (presubmit successful).

Expand Messages | Collapse Messages