Issue 342383002: Allow "null" as a synonym for [] or {} in the analysis server API.

Issue 342383002: Allow "null" as a synonym for [] or {} in the analysis server API. (Closed)

Created:
6 years, 6 months ago by Paul Berry

Modified:
6 years, 6 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow "null" as a synonym for [] or {} in the analysis server API. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=37608

Patch Set 1 #

Total comments: 4

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+201 lines, -41 lines)			Patch
	M	pkg/analysis_server/lib/src/protocol.dart	View		10 chunks	+76 lines, -41 lines	4 comments	Download
	M	pkg/analysis_server/test/protocol_test.dart	View		9 chunks	+125 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/342383002/diff/1/pkg/analysis_server/lib/src/protocol.dart File pkg/analysis_server/lib/src/protocol.dart (right): https://codereview.chromium.org/342383002/diff/1/pkg/analysis_server/lib/src/protocol.dart#newcode144 pkg/analysis_server/lib/src/protocol.dart:144: Object value = params[name]; Remove this line, given ...

6 years, 6 months ago (2014-06-21 03:24:51 UTC) #2

Paul Berry

https://codereview.chromium.org/342383002/diff/1/pkg/analysis_server/lib/src/protocol.dart File pkg/analysis_server/lib/src/protocol.dart (right): https://codereview.chromium.org/342383002/diff/1/pkg/analysis_server/lib/src/protocol.dart#newcode144 pkg/analysis_server/lib/src/protocol.dart:144: Object value = params[name]; On 2014/06/21 03:24:51, Brian Wilkerson ...

6 years, 6 months ago (2014-06-23 16:51:45 UTC) #3

Paul Berry

6 years, 6 months ago (2014-06-23 16:52:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r37608 (presubmit successful).

Expand Messages | Collapse Messages