Issue 34233003: dart:io | Add test of command-line arguments passed to main, remove test of Options object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 34233003: dart:io | Add test of command-line arguments passed to main, remove test of Options object. (Closed)

Created:
7 years, 2 months ago by Bill Hesse

Modified:
7 years, 2 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart:io | Add test of command-line arguments passed to main, remove test of Options object. BUG= R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=28989

Patch Set 2 : Add comment to status file. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -36 lines)			Patch
A	tests/standalone/io/arguments_test.dart	View		1 chunk	+17 lines, -0 lines	0 comments	Download
D	tests/standalone/io/options_test.dart	View		1 chunk	+0 lines, -34 lines	0 comments	Download
M	tests/standalone/standalone.status	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM, with comments. https://codereview.chromium.org/34233003/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://codereview.chromium.org/34233003/diff/1/tests/standalone/standalone.status#newcode141 tests/standalone/standalone.status:141: io/arguments_test: Fail Why is this failing?

7 years, 2 months ago (2013-10-22 09:26:22 UTC) #2

Bill Hesse

7 years, 2 months ago (2013-10-22 09:38:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r28989 (presubmit successful).

Expand Messages | Collapse Messages

Issue 34233003: dart:io | Add test of command-line arguments passed to main, remove test of Options object. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add comment to status file. #

Messages