Throw a StateError if read()/readAsString() is called multiple times

Throw a StateError if read()/readAsString() is called multiple times

R=kevmoo@google.com, sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37584

[Søren Gjesse, 2014-06-20 14:41:33]

lgtm

[kevmoo, 2014-06-20 15:40:02]

Adding Nathan

LGTM

I've pondered this a bit. Wondering if we should have a model for non-stream
content that can be re-read.

[kevmoo, 2014-06-20 15:42:26]

Plus nit

https://codereview.chromium.org/342323004/diff/1/dart/pkg/shelf/lib/src/messa...
File dart/pkg/shelf/lib/src/message.dart (right):

https://codereview.chromium.org/342323004/diff/1/dart/pkg/shelf/lib/src/messa...
dart/pkg/shelf/lib/src/message.dart:109: throw new StateError("The 'read()'
method can only be called once on a "
Change to "The 'read' method can only be called once."

[kustermann, 2014-06-23 08:31:03]

Thanks

> I've pondered this a bit. Wondering if we should have a model for non-stream
content that can be re-read.

A user of a shelf.Request/shelf.Response cannot just assume that it can
re-read() and listen to the stream again. It would be a "special"
shelf.Request/shelf.Response. Of course if you want to have that behavior, you
could make subclasses where the instantiator knows what it can do with it ...

It even does ownership tracking, look here:

var file = new File(...).openRead();
var request = new Request(body: file);
var changedRequest = request.change(uri: '...');

At this point 'changedRequest' will have the stream. You can call
'changedRequest.read()' but you cannot call 'request.read()' anymore (the
ownership of the stream has been transferred to 'changedRequest').

https://codereview.chromium.org/342323004/diff/1/dart/pkg/shelf/lib/src/messa...
File dart/pkg/shelf/lib/src/message.dart (right):

https://codereview.chromium.org/342323004/diff/1/dart/pkg/shelf/lib/src/messa...
dart/pkg/shelf/lib/src/message.dart:109: throw new StateError("The 'read()'
method can only be called once on a "
On 2014/06/20 15:42:25, kevmoo wrote:
> Change to "The 'read' method can only be called once."

Done.

[kustermann, 2014-06-23 08:31:37]

Committed patchset #2 manually as r37584 (presubmit successful).