Fix prop_attr_reflection_test in drt/dartium (fixes issue 14295)

Fix prop_attr_reflection_test in drt/dartium (fixes issue 14295)

R=jmesserly@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29005

[Siggi Cherem (dart-lang), 2013-10-22 01:40:31]

https://codereview.chromium.org/34213002/diff/1/pkg/polymer/test/prop_attr_re...
File pkg/polymer/test/prop_attr_reflection_test.dart (right):

https://codereview.chromium.org/34213002/diff/1/pkg/polymer/test/prop_attr_re...
pkg/polymer/test/prop_attr_reflection_test.dart:40: Platform.flush();
Not sure if you prefer to fix this in some other way.

Here is what happened: this code used to be called within the
dirty-checking-zone when we used @initMethod below. When I changed the test to
use main, this code started being executed in the top-level zone.

[Jennifer Messerly, 2013-10-22 05:51:50]

lgtm

https://codereview.chromium.org/34213002/diff/1/pkg/polymer/test/prop_attr_re...
File pkg/polymer/test/prop_attr_reflection_test.dart (right):

https://codereview.chromium.org/34213002/diff/1/pkg/polymer/test/prop_attr_re...
pkg/polymer/test/prop_attr_reflection_test.dart:40: Platform.flush();
On 2013/10/22 01:40:31, Siggi Cherem (dart-lang) wrote:
> Not sure if you prefer to fix this in some other way.
> 
> Here is what happened: this code used to be called within the
> dirty-checking-zone when we used @initMethod below. When I changed the test to
> use main, this code started being executed in the top-level zone.

yeah, this is fine ... however, out of curiosity what would it take to have
things in the zone? it seems a bit dangerous if our main/initPolymer pattern
doesn't lead people down the path of running Polymer code in a zone.

Maybe initPolymer sound take a callback for that purpose? Or some other way of
making the zone more obvious?

[Siggi Cherem (dart-lang), 2013-10-22 16:14:52]

On 2013/10/22 05:51:50, John Messerly wrote:
> lgtm
> 
>
https://codereview.chromium.org/34213002/diff/1/pkg/polymer/test/prop_attr_re...
> File pkg/polymer/test/prop_attr_reflection_test.dart (right):
> 
>
https://codereview.chromium.org/34213002/diff/1/pkg/polymer/test/prop_attr_re...
> pkg/polymer/test/prop_attr_reflection_test.dart:40: Platform.flush();
> On 2013/10/22 01:40:31, Siggi Cherem (dart-lang) wrote:
> > Not sure if you prefer to fix this in some other way.
> > 
> > Here is what happened: this code used to be called within the
> > dirty-checking-zone when we used @initMethod below. When I changed the test
to
> > use main, this code started being executed in the top-level zone.
> 
> yeah, this is fine ... however, out of curiosity what would it take to have
> things in the zone? it seems a bit dangerous if our main/initPolymer pattern
> doesn't lead people down the path of running Polymer code in a zone.
> 
> Maybe initPolymer sound take a callback for that purpose? Or some other way of
> making the zone more obvious?

that's a good question, might be good to brainstorm some more.

[Siggi Cherem (dart-lang), 2013-10-22 16:18:20]

Committed patchset #1 manually as r29005 (presubmit successful).