Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 341923005: Update imports to use package:compiler and package:try. (Closed)

Created:
6 years, 6 months ago by ahe
Modified:
6 years, 6 months ago
CC:
reviews_dartlang.org, Alan Knight, Emily Fortuna
Visibility:
Public.

Description

Update imports to use package:compiler and package:try. R=floitsch@google.com, johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=37538

Patch Set 1 #

Patch Set 2 : Merged with r37512. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -307 lines) Patch
M dart/pkg/docgen/lib/src/exports/dart2js_mirrors.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/pkg/docgen/lib/src/exports/mirrors_util.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/pkg/docgen/lib/src/exports/source_mirrors.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/pkg/docgen/lib/src/generator.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M dart/pkg/docgen/lib/src/models/annotation.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/analyze_dart2js_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/analyze_helper.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M dart/tests/compiler/dart2js/analyze_only_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/async_compiler_input_provider_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/bad_loop_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/bad_output_io_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M dart/tests/compiler/dart2js/begin_end_token_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/call_site_simple_type_inferer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/command_line_split_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/compiler_helper.dart View 2 chunks +13 lines, -13 lines 0 comments Download
M dart/tests/compiler/dart2js/compiler_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M dart/tests/compiler/dart2js/cpa_inference_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M dart/tests/compiler/dart2js/dart_backend_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M dart/tests/compiler/dart2js/dart_printer_test.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M dart/tests/compiler/dart2js/deferred_dont_inline_deferred_constants_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/deferred_emit_type_checks_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/deferred_follow_constant_dependencies_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/deferred_follow_implicit_super_regression_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/deferred_load_graph_segmentation2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/deferred_load_graph_segmentation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/deferred_mirrors_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/deferred_not_in_main_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/diagnose_ambiguous_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/dump_info_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/erroneous_element_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M dart/tests/compiler/dart2js/exit_code_test.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M dart/tests/compiler/dart2js/field_type_simple_inferer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/find_my_name_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/js_parser_statements_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/js_parser_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/least_upper_bound_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M dart/tests/compiler/dart2js/link_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/list_tracer2_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/list_tracer3_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/list_tracer_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/lookup_member_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/map_tracer_keys_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/map_tracer_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/members_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M dart/tests/compiler/dart2js/memory_compiler.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M dart/tests/compiler/dart2js/memory_source_file_helper.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M dart/tests/compiler/dart2js/message_kind_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/message_kind_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/metadata_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/mirror_helper_rename_test.dart View 1 chunk +4 lines, -8 lines 0 comments Download
M dart/tests/compiler/dart2js/mirror_helper_test.dart View 1 chunk +5 lines, -14 lines 0 comments Download
M dart/tests/compiler/dart2js/mirror_helper_unique_minification_test.dart View 1 chunk +5 lines, -10 lines 0 comments Download
M dart/tests/compiler/dart2js/mirror_system_helper.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M dart/tests/compiler/dart2js/mirror_tree_shaking_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M dart/tests/compiler/dart2js/mirrors/mirrors_reader_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M dart/tests/compiler/dart2js/mirrors/mirrors_test_helper.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M dart/tests/compiler/dart2js/mirrors_exports_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/mirrors_lookup_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/mirrors_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M dart/tests/compiler/dart2js/mirrors_used_test.dart View 1 chunk +8 lines, -7 lines 0 comments Download
M dart/tests/compiler/dart2js/missing_file_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/mixin_typevariable_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/mock_compiler.dart View 1 chunk +9 lines, -9 lines 0 comments Download
M dart/tests/compiler/dart2js/override_inheritance_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/package_root_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/parser_helper.dart View 1 chunk +9 lines, -9 lines 0 comments Download
M dart/tests/compiler/dart2js/parser_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/part_of_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/patch_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M dart/tests/compiler/dart2js/private_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/reexport_handled_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/resolution_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/resolver_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M dart/tests/compiler/dart2js/scanner_offset_length_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/scanner_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/setlet_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/simple_inferrer_callers_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/simple_inferrer_relations_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M dart/tests/compiler/dart2js/simple_inferrer_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M dart/tests/compiler/dart2js/simple_inferrer_try_catch_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/source_map_d2js_validity_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/source_mapping_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M dart/tests/compiler/dart2js/space_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/stats_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/strip_comment_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/subtype_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/type_checker_test.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M dart/tests/compiler/dart2js/type_combination_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/type_equals_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/type_mask_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/type_mask_test_helper.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/type_order_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/type_representation_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M dart/tests/compiler/dart2js/type_substitution_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/type_test_helper.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M dart/tests/compiler/dart2js/type_variable_occurrence_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/union_type_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/unneeded_part_js_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/unparser2_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M dart/tests/compiler/dart2js/unparser_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/uri_extras_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/value_range2_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M dart/tests/compiler/dart2js/warnings_checker.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M dart/tests/try/cursor_position_test.dart View 1 1 chunk +0 lines, -2 lines 0 comments Download
M dart/tests/try/internal_error_test.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M dart/tests/try/mock_try.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M dart/tests/try/paste_content_rewriting_test.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M dart/tests/try/source_update_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M dart/tests/try/test_try.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/utils/dart2js_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/utils/dummy_compiler_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/utils/recursive_import_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/utils/source_mirrors_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/utils/apidoc/docgen.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ahe
6 years, 6 months ago (2014-06-19 16:45:33 UTC) #1
Johnni Winther
LGTM though it makes DartEditor think that package:compiler is different from sdk/lib/_internal/compiler on Windows.
6 years, 6 months ago (2014-06-20 07:48:25 UTC) #2
ahe
On 2014/06/20 07:48:25, Johnni Winther wrote: > LGTM though it makes DartEditor think that package:compiler ...
6 years, 6 months ago (2014-06-20 08:04:45 UTC) #3
Johnni Winther
On 2014/06/20 08:04:45, ahe wrote: > On 2014/06/20 07:48:25, Johnni Winther wrote: > > LGTM ...
6 years, 6 months ago (2014-06-20 08:40:03 UTC) #4
ahe
Florian, I don't want to submit this without your knowledge. Any concerns about this?
6 years, 6 months ago (2014-06-20 08:53:11 UTC) #5
floitsch
LGTM.
6 years, 6 months ago (2014-06-20 08:59:24 UTC) #6
ahe
6 years, 6 months ago (2014-06-20 10:34:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r37538 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698