Issue 341893010: Use "pub list-package-dirs" to resolve package URIs in analysis server.

Issue 341893010: Use "pub list-package-dirs" to resolve package URIs in analysis server. (Closed)

Created:
6 years, 6 months ago by Paul Berry

Modified:
6 years, 6 months ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use "pub list-package-dirs" to resolve package URIs in analysis server. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=37552

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+206 lines, -53 lines)			Patch
M	pkg/analysis_server/lib/src/analysis_server.dart	View	7 chunks	+15 lines, -37 lines	0 comments	Download
A	pkg/analysis_server/lib/src/package_map_provider.dart	View	1 chunk	+100 lines, -0 lines	1 comment	Download
M	pkg/analysis_server/lib/src/socket_server.dart	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/analysis_abstract.dart	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/analysis_server_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/domain_analysis_test.dart	View	3 chunks	+8 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/test/domain_completion_test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/domain_edit_test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/domain_search_test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/domain_server_test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/mocks.dart	View	2 chunks	+17 lines, -5 lines	0 comments	Download
A	pkg/analysis_server/test/package_map_provider_test.dart	View	1 chunk	+47 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/test_all.dart	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

Committed patchset #1 manually as r37552 (presubmit successful).

6 years, 6 months ago (2014-06-20 14:42:10 UTC) #3

Brian Wilkerson

LGTM https://codereview.chromium.org/341893010/diff/1/pkg/analysis_server/lib/src/package_map_provider.dart File pkg/analysis_server/lib/src/package_map_provider.dart (right): https://codereview.chromium.org/341893010/diff/1/pkg/analysis_server/lib/src/package_map_provider.dart#newcode52 pkg/analysis_server/lib/src/package_map_provider.dart:52: AnalysisEngine.instance.logger.logInformation( These errors seems like something we should ...

6 years, 6 months ago (2014-06-20 14:42:46 UTC) #4

Paul Berry

6 years, 6 months ago (2014-06-20 14:45:36 UTC) #5

Message was sent while issue was closed.

On 2014/06/20 14:42:46, Brian Wilkerson wrote:
> LGTM
> 
>
https://codereview.chromium.org/341893010/diff/1/pkg/analysis_server/lib/src/...
> File pkg/analysis_server/lib/src/package_map_provider.dart (right):
> 
>
https://codereview.chromium.org/341893010/diff/1/pkg/analysis_server/lib/src/...
> pkg/analysis_server/lib/src/package_map_provider.dart:52:
> AnalysisEngine.instance.logger.logInformation(
> These errors seems like something we should report back to the client so that
> they can inform the user and/or correct the problem.

That's fair.  I'm not exactly sure the best way to go about this (we'll need to
invent some protocol, and it seems like it would be worth trying to make it
general enough to handle more than this just one case).  Let's talk next week
when you're back in the office.

Expand Messages | Collapse Messages