Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 341843003: Remove use of deprecated property in TodoMVC (Closed)

Created:
6 years, 6 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 6 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove use of deprecated property in TodoMVC R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=37466

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M pkg/polymer/CHANGELOG.md View 1 1 chunk +6 lines, -1 line 0 comments Download
M samples/searchable_list/web/elements/searchable_list.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M samples/third_party/todomvc/web/elements/td_todos.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/third_party/todomvc/web/lib-elements/simple_router.dart View 1 2 chunks +4 lines, -2 lines 0 comments Download
M samples/third_party/todomvc_performance/web/lib-elements/simple_router.dart View 1 2 chunks +4 lines, -2 lines 0 comments Download
M samples/tracker/web/elements/task_form_element.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Siggi Cherem (dart-lang)
6 years, 6 months ago (2014-06-18 16:58:25 UTC) #1
Jennifer Messerly
lgtm. though I wonder if the baseUri workaround is even needed anymore :)
6 years, 6 months ago (2014-06-18 18:49:18 UTC) #2
Siggi Cherem (dart-lang)
It was still needed - trying to test it I realized that the route was ...
6 years, 6 months ago (2014-06-18 20:33:03 UTC) #3
Jennifer Messerly
On 2014/06/18 20:33:03, Siggi Cherem (dart-lang) wrote: > It was still needed - trying to ...
6 years, 6 months ago (2014-06-18 21:02:50 UTC) #4
Siggi Cherem (dart-lang)
6 years, 6 months ago (2014-06-18 21:04:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r37466 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698