Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 341533005: Change contract for ChangeSet to reflect AnalysisContext behavior. (Closed)

Created:
6 years, 6 months ago by Paul Berry
Modified:
6 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Change contract for ChangeSet to reflect AnalysisContext behavior. The analysis server relies on changedSources having no effect on files whose contents are already overridden, and we don't want to rely on undefined behavior. This shouldn't affect any clients; we are just specifying the behavior that already existed. Also, avoid unnecessarily invalidating analysis when changedSources contains a source that is already overridden. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=37426

Patch Set 1 #

Messages

Total messages: 3 (0 generated)
Paul Berry
6 years, 6 months ago (2014-06-17 20:25:15 UTC) #1
Brian Wilkerson
LGTM
6 years, 6 months ago (2014-06-17 20:30:03 UTC) #2
Paul Berry
6 years, 6 months ago (2014-06-17 21:22:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37426 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698