Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 341473002: Add deferred_mirrors failures to test status. (Closed)

Created:
6 years, 6 months ago by Bill Hesse
Modified:
6 years, 6 months ago
Reviewers:
vsm, kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add deferred_mirrors failures to test status. BUG=dartbug.com/19449 R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=37387

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move sections and merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -26 lines) Patch
M tests/lib/lib.status View 1 4 chunks +16 lines, -26 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bill Hesse
6 years, 6 months ago (2014-06-17 07:58:02 UTC) #1
vsm
https://codereview.chromium.org/341473002/diff/1/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/341473002/diff/1/tests/lib/lib.status#newcode279 tests/lib/lib.status:279: [ $compiler == none && ($runtime == dartium || ...
6 years, 6 months ago (2014-06-17 08:00:22 UTC) #2
vsm
lgtm with the format fixes
6 years, 6 months ago (2014-06-17 08:01:21 UTC) #3
Bill Hesse
6 years, 6 months ago (2014-06-17 08:27:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r37387 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698