Issue 341433009: Pub global deactivate command.

Issue 341433009: Pub global deactivate command. (Closed)

Created:
6 years, 5 months ago by Bob Nystrom

Modified:
6 years, 5 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Pub global deactivate command. BUG=https://code.google.com/p/dart/issues/detail?id=18538 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=37837

Patch Set 1 #

Total comments: 5

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -30 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/command/global.dart	View	2 chunks	+3 lines, -1 line	0 comments	Download
A	sdk/lib/_internal/pub/lib/src/command/global_deactivate.dart	View	1 chunk	+35 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/global_packages.dart	View	5 chunks	+21 lines, -3 lines	4 comments	Download
M	sdk/lib/_internal/pub/test/global/activate/unknown_package_test.dart	View	2 chunks	+2 lines, -1 line	0 comments	Download
A +	sdk/lib/_internal/pub/test/global/deactivate/deactivate_and_reactivate_package_test.dart	View	1 chunk	+10 lines, -7 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/global/deactivate/deactivate_package_test.dart	View	1 chunk	+6 lines, -6 lines	1 comment	Download
A +	sdk/lib/_internal/pub/test/global/deactivate/missing_package_arg_test.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/global/deactivate/unexpected_arguments_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/global/deactivate/unknown_package_test.dart	View	1 chunk	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/341433009/diff/1/sdk/lib/_internal/pub/lib/src/global_packages.dart File sdk/lib/_internal/pub/lib/src/global_packages.dart (right): https://codereview.chromium.org/341433009/diff/1/sdk/lib/_internal/pub/lib/src/global_packages.dart#newcode115 sdk/lib/_internal/pub/lib/src/global_packages.dart:115: var lockFilePath = p.join(_directory, name + ".lock"); Nit: ...

6 years, 5 months ago (2014-06-30 20:59:05 UTC) #2

Bob Nystrom

Committed patchset #1 manually as r37837 (presubmit successful).

6 years, 5 months ago (2014-06-30 21:35:29 UTC) #3

Bob Nystrom

6 years, 5 months ago (2014-06-30 21:35:52 UTC) #4

Message was sent while issue was closed.

Thanks!

https://codereview.chromium.org/341433009/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/global_packages.dart (right):

https://codereview.chromium.org/341433009/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/global_packages.dart:115: var lockFilePath =
p.join(_directory, name + ".lock");
On 2014/06/30 20:59:04, nweiz wrote:
> Nit: I'd write "$name.lock"

Done.

https://codereview.chromium.org/341433009/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/global_packages.dart:143: dataError("Package
$package has no versions that match $constraint.");
On 2014/06/30 20:59:04, nweiz wrote:
> Why is this line added? If it's here, shouldn't the next line be removed?

Oops. Merge mistake. Fixed.

Expand Messages | Collapse Messages